Skip to content
This repository was archived by the owner on May 26, 2024. It is now read-only.

Conversation

ShiroTohu
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Breaking Change
  • Documentation Update

Description

I have just updated the code style to account for documentation styles. This will help me write the documentation and keep it consistent as well. It's a good reference.

Note

I the code style I wrote a little bit of a reference as to the styling of the parameter, attribute and method documentation. I think this could use some work, but since I am the only contributor, for the time being it should be alright.

Added changes

  • Added parameter, attribute and method markdown documentation styles
  • Added code block shorthand as standard
  • Added Nextra callout documentation as well for reference
  • Updated table of contents

Note

I also want to point out that I understand when writing the documentation, we kind of want to use the signature of whatever we are documenting with their types etc. This isn't present present in the code style markdown file. I might create an issue and put it in the backlog, while we focus on other things.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: code style update
  • I need help with writing tests

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thread-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 3:23am

Copy link
Member

@caffeine-addictt caffeine-addictt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caffeine-addictt caffeine-addictt merged commit 4ebe5bf into python-thread:staging Jan 24, 2024
@ShiroTohu ShiroTohu deleted the shirotohu-update-codestyle branch January 26, 2024 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants