Skip to content
This repository has been archived by the owner on Dec 27, 2021. It is now read-only.

Added ability to specify return codes. #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbzdak
Copy link
Contributor

@jbzdak jbzdak commented Jan 2, 2014

When getting returncode other than 0 fabric raises SystemExit error by default, which is very unformtuate, since it is one exception you really shouldn't catch in Python.

You can of course use fabric.api.settings(warn_only=True, but you have to know of its existence, which can be hard. And we force user to use api other than provy api. I added a small feature that allows user to specify return codes that are considered as succesfull execurion, and if process return other return code I raise sane CommandExecutionError).

Let me know if any further changes are neccessary.

@jbzdak
Copy link
Contributor Author

jbzdak commented Feb 20, 2014

This requires some more work, it breaks some existing functionality.

For now it overrrides any warn_only setting set by any other code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant