Drop python 3.9 support #930
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
ashb
reviewed
Jan 10, 2026
clock
Outdated
| v = ( | ||
| self.format_dict(v, tab + 1) | ||
| if isinstance(v, (dict, LocaleDataDict)) | ||
| if isinstance(v, dict | LocaleDataDict) |
Member
There was a problem hiding this comment.
@Secrus wdyt of this syntax? Personally i somehow prefer the tuple version still
Collaborator
There was a problem hiding this comment.
Yeah, I think it's a matter of old version of ruff, they deprecated this change in new versions IIRC.
mattwang44
force-pushed
the
drop-python39
branch
from
149d533 to
4f03ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop python 3.9 support as it has reached EOL