Skip to content

fix(test): time_machine.Coordinates is renamed to time_machine.Travaller #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattwang44 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(test): time_machine.Coordinates is renamed to time_machine.Travaller #927

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
007a7b0
fix(test): time_machine.Coordinates is renamed
mattwang44 Dec 13, 2025
0c554fa
refactor(test): rename traveller private var names
mattwang44 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/pendulum/testing/traveller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ def __init__(self, datetime_class: type[DateTime] = DateTime) -> None:
super().__init__(datetime_class)

self._started: bool = False
self._traveller: time_machine.travel | None = None
self._coordinates: time_machine.Coordinates | None = None
self._travel: time_machine.travel | None = None
self._traveller: time_machine.Traveller | None = None

def freeze(self) -> Self:
if self._started:
cast("time_machine.Coordinates", self._coordinates).move_to(
cast("time_machine.Traveller", self._traveller).move_to(
self._datetime_class.now(), tick=False
)
else:
Expand All @@ -83,9 +83,9 @@ def travel_back(self) -> Self:
if not self._started:
return self

cast("time_machine.travel", self._traveller).stop()
self._coordinates = None
cast("time_machine.travel", self._travel).stop()
self._traveller = None
self._travel = None
self._started = False

return self
Expand All @@ -105,7 +105,7 @@ def travel(
) -> Self:
self._start(freeze=freeze)

cast("time_machine.Coordinates", self._coordinates).move_to(
cast("time_machine.Traveller", self._traveller).move_to(
self._datetime_class.now().add(
years=years,
months=months,
Expand All @@ -123,20 +123,20 @@ def travel(
def travel_to(self, dt: DateTime, *, freeze: bool = False) -> Self:
self._start(freeze=freeze)

cast("time_machine.Coordinates", self._coordinates).move_to(dt)
cast("time_machine.Traveller", self._traveller).move_to(dt)

return self

def _start(self, freeze: bool = False) -> None:
if self._started:
return

if not self._traveller:
self._traveller = time_machine.travel(
if not self._travel:
self._travel = time_machine.travel(
self._datetime_class.now(), tick=not freeze
)

self._coordinates = self._traveller.start()
self._traveller = self._travel.start()

self._started = True

Expand Down