local_timezone: gracefully handle retrieval errors on Darwin#792
Open
tpwrules wants to merge 1 commit intopython-pendulum:masterfrom
Open
local_timezone: gracefully handle retrieval errors on Darwin#792tpwrules wants to merge 1 commit intopython-pendulum:masterfrom
tpwrules wants to merge 1 commit intopython-pendulum:masterfrom
Conversation
CodSpeed Performance ReportMerging #792 will not alter performanceComparing Summary
|
In some sandbox environments, the program may not have permission to access /etc/localtime or it may not exist. Catch any exceptions accessing and parsing its value and return UTC by default to avoid crashing the program.
tpwrules
force-pushed
the
darwin-error-handling
branch
from
a4d98ce to
ba57bed
Compare
Author
|
Fixed formatting. |
Author
|
Still interested in getting this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some sandbox environments, the program may not have permission to access /etc/localtime or it may not exist.
Catch any exceptions accessing and parsing its value and return UTC by default to avoid crashing the program.
Pull Request Check List