Fix parsing exception when trailing/leading slash#505
Open
fffaez wants to merge 2 commits intopython-pendulum:masterfrom
fffaez:master
Open
Fix parsing exception when trailing/leading slash#505fffaez wants to merge 2 commits intopython-pendulum:masterfrom fffaez:master
fffaez wants to merge 2 commits intopython-pendulum:masterfrom
fffaez:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everybody, I am new here 🙂
I fix the
_iso8601_intervalparsing accordingly to deal with this edge case so the outer parse could raise a properValueError.Fixes #506
Pull Request Check List
Added tests for changed code.
Updated documentation for changed code.