Skip to content

add picoquant taiko m1 support #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

barentine
Copy link
Member

Addresses issue I have a PicoQuant Taiko M1 that I need to mess with in a protocol, so I've added an interface for it.

It's a pretty flexible laser, which is quite cool / something I take advantage of, but it means there's a lot to interface (pulsed int / ext, CW operation).

There's a good chance its worth writing a threaded version that uses it's "tag" functionality to query a whole list of things at once, so we can get everything we need to construct a fairly complicated scope state with a single serial command, but I figure let me run into a performance issue before I try and fix it

Is this a bugfix or an enhancement?
enhancement
Proposed changes:

@David-Baddeley
Copy link
Contributor

@barentine - Looking at the license on pdlm.py, It's a bit unclear whether we can merge/ distribute it. The first thing I saw was

"You may not distribute the software to third parties"

but it then goes on to say that you can modify and distribute the demo code, which makes me think the first statement applied to the driver code, not the file in which it was found. In either case the combined statement is extremely unclear. I wonder if it might be worth reaching out to Picoquant to clarify and/or offering an alternative along the lines of:

"This code is modified from the demo code provided by PicoQuant GmbH for interfacing with the PDLM driver.
You may use and modify demo code to create your own software. Original or modified demo code
may be re-distributed, provided that the original disclaimer and notes are not removed from it.

Possession of this modified demo code does not confer any rights to the PDLM driver
software itself. The PDLM driver software is protected by copyright and intellectual property laws.
You may not distribute the PDLM driver software to third parties or reverse engineer, decompile or disassemble
the software or any part thereof. Copyright of all product documentation belongs to PicoQuant GmbH.
No parts of it may be reproduced or translated into other languages without written consent of PicoQuant GmbH.
"

@barentine
Copy link
Member Author

thanks @David-Baddeley . I'll send an email to PicoQuant and keep you posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants