Allow method handlers to return json rpc errors#20
Merged
Conversation
Contributor
Author
|
@ccordoba12 I noticed a bug and it looks like CI caught it as well; pushed a fix and it should hopefully pass now if you kick it. |
ccordoba12
changed the title
ccordoba12
approved these changes
Sep 7, 2023
ccordoba12
left a comment
ccordoba12
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks for your help with this @smacke!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we allow method handlers to return results that could themselves contain "result" and "error" fields. If they contain neither field, the old behavior is maintained. If they contain one or both fields, however, we read those fields and use them in the json rpc response.
This will be useful for addressing python-lsp/python-lsp-server#314 -- rather than raising an exception when we get a request post-shutdown, we'll be able to instead call a method that returns a json rpc invalid request.
See also python-lsp/python-lsp-server#432