Report huge durations as invalid instead of raising decimal.Overflow#1532
Open
cognis-digital wants to merge 1 commit into
Open
Report huge durations as invalid instead of raising decimal.Overflow#1532cognis-digital wants to merge 1 commit into
cognis-digital wants to merge 1 commit into
Conversation
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1511.
The
durationformat checker delegates toisoduration.parse_duration, which parses each numeric component withDecimal(...). When a component's magnitude exceeds the decimal context'sEmax(e.g.P1E1000000D, or a digit run longer thanEmax),Decimalraisesdecimal.Overflow. Because the checker was registered only withraises=isoduration.DurationParsingException, anddecimal.Overflowis anArithmeticErrorrather than aDurationParsingException, the exception propagated uncaught out of format validation instead of the instance being reported invalid.Such strings are not valid RFC 3339 Appendix A durations (the grammar is
1*DIGIT, no exponent), so they should be reported invalid. This broadens the checker's caught exceptions to includedecimal.Overflow.Added regression tests for both the large-exponent and long-digit-run cases, guarded with
skipUnlessso they skip when the optionalisodurationdependency isn't installed.