Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecodedURL #54

Merged
merged 28 commits into from
Jan 7, 2018
Merged

DecodedURL #54

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
98edfc6
WIP DecodedURL with path and replace
mahmoud Dec 17, 2017
dce971b
DecodedURL.replace(query) and DecodedURL.query working. Fix up userin…
mahmoud Dec 18, 2017
2162c67
DecodedURL userinfo now working
mahmoud Dec 18, 2017
d1bfc68
add new arguments to _percent_decode and use them in the DecodedURL
mahmoud Dec 30, 2017
adc7370
added DecodedURL to the public API, started on tests, added DecodedUR…
mahmoud Dec 31, 2017
fc28ee3
add host and port to DecodedURL
mahmoud Dec 31, 2017
358402f
add DecodedURL.scheme property, plus some more tests
mahmoud Dec 31, 2017
34d4212
add and test a bunch of DecodedURL passthrough methods
mahmoud Dec 31, 2017
161e93a
test DecodedURL userinfo-related properties. Add generic percent enco…
mahmoud Dec 31, 2017
95ea9ea
add, test, and slightly refactor query manipulation methods. still pr…
mahmoud Dec 31, 2017
976c083
fix and test the aforementioned issue with query parameters which are…
mahmoud Dec 31, 2017
02a841c
bit of housekeeping on DecodedURL, rearranging and adding a couple mi…
mahmoud Dec 31, 2017
9a0438e
DecodedURL: made .query a tuple. more obvious errors on attempted mut…
mahmoud Dec 31, 2017
662ec79
DecodedURL.replace() now fixed and tested working for roundtripping U…
mahmoud Dec 31, 2017
3aa4b61
add some Twisted-style methods to DecodedURL for consistency with URL…
mahmoud Dec 31, 2017
82deb29
some notes and docs on DecodedURL
mahmoud Dec 31, 2017
0b311d7
split out host decoding to its own function, remove duplicated code
mahmoud Jan 1, 2018
30e19a6
fix delimiter typo in docstring, thanks alex!
mahmoud Jan 1, 2018
696e8fd
add parse convenience function and EncodedURL alias for URL to top-le…
mahmoud Jan 1, 2018
67ab0ec
add lazy keyword to DecodedURL methods where appropriate. Add some co…
mahmoud Jan 1, 2018
6a90f4a
DecodedURL pretty much fully covered by tests
mahmoud Jan 6, 2018
ad63b9b
docstrings for all DecodedURL members
mahmoud Jan 6, 2018
afc907b
cover another line in _percent_decode
mahmoud Jan 6, 2018
9f3212b
Merge branch 'master' into i44_decoded_url
mahmoud Jan 6, 2018
ac3be79
fixing test coverage for parse
mahmoud Jan 6, 2018
dd8248c
Merge branch 'i44_decoded_url' of github.com:python-hyper/hyperlink i…
mahmoud Jan 6, 2018
6dd3272
DecodedURL: address most of the comments about docstrings
mahmoud Jan 7, 2018
e8616fa
add a few more DecodedURL/parse tests and a couple comments
mahmoud Jan 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
* Get coverage up
* Switch off ctypes/socket for IP validation
* rebase method for path (prepends to path)
* switch default percent encoding to upper case (a la RFC 3986 2.1)
* sibling() should be maximal=False like child()
* make subencoding an exposed parameter

## normalize method

Expand Down
11 changes: 9 additions & 2 deletions hyperlink/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@

from ._url import URL, URLParseError, register_scheme, parse_host
from ._url import (URL,
parse,
EncodedURL,
DecodedURL,
URLParseError,
register_scheme)

__all__ = [
"URL",
"parse",
"EncodedURL",
"DecodedURL",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to say that we should just avoid exposing this entirely, but it probably needs to be exposed for type annotations.

However, as per #44, could we have a "decoded" property on URL that provides an interface to this, and an "encoded" property on DecodedURL that maps back to a URL?

(At this point I think I'm in favor of adding an EncodedURL alias for URL, then maybe adding a top-level entry point like hyperlink.parse() which takes a decoded kwarg flag which defaults to true, to make it easier to get started with DecodedURL which is what I think we all want most of the time. That can definitely be deferred to a separate ticket though.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am pretty much in favor of all those conveniences :) And I also agree that this probably needs to be exposed.

"URLParseError",
"register_scheme",
"parse_host"
]
Loading