Add extension frame support. #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Specifically, the first two commits are the ones that need backporting. |
Lukasa
force-pushed
the
add-extension-frame-support
branch
from
4571002 to
dcfcf34
Compare
alexwlchan
reviewed
Mar 7, 2017
alexwlchan
approved these changes
Mar 8, 2017
h2/connection.py
Outdated
| """ | ||
| # All we do here is log. | ||
| self.config.logger.debug( | ||
| "Received unknown extension frame (ID 0x%x)", frame.stream_id |
There was a problem hiding this comment.
Elsewhere we log the stream ID as a %d integer. Should we be consistent in the way we log?
There was a problem hiding this comment.
FWIW, I would probably lean towards doing logging in hex as you did it originally, but let’s make that a separate patch.
Lukasa
force-pushed
the
add-extension-frame-support
branch
from
dcfcf34 to
04cf12d
Compare
|
Okay, LGTM. @Lukasa I’ll let you merge, so you can sort out backports and the like. |
|
Cool, thanks @alexwlchan! I'm going to try to write this in as a shell script that we can commit to the repo so that backporting gets a bit easier. |
Lukasa
added a commit
that referenced
this pull request
Mar 8, 2017
Merged
Lukasa
added a commit
that referenced
this pull request
Mar 8, 2017
Merged
Lukasa
added a commit
that referenced
this pull request
Mar 8, 2017
Merged
Lukasa
added a commit
that referenced
this pull request
Mar 8, 2017
Lukasa
added a commit
that referenced
this pull request
Mar 8, 2017
Lukasa
added a commit
that referenced
this pull request
Mar 8, 2017
Lukasa
added a commit
that referenced
this pull request
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for emitting events when we receive extension frames.
Resolves #435.
The first few commits in here should be backported to older versions of hyper-h2 to allow them to use the 5.0 release series of hyperframe if needed.