Conversation
|
Specifically, the first two commits are the ones that need backporting. |
Lukasa
force-pushed
the
add-extension-frame-support
branch
from
4571002 to
dcfcf34
Compare
alexwlchan
left a comment
alexwlchan
left a comment
There was a problem hiding this comment.
Looks good on an initial skim, will review properly later.
alexwlchan
left a comment
alexwlchan
left a comment
There was a problem hiding this comment.
One suggestion about logging consistency, otherwise LGTM.
h2/connection.py
Outdated
| """ | ||
| # All we do here is log. | ||
| self.config.logger.debug( | ||
| "Received unknown extension frame (ID 0x%x)", frame.stream_id |
There was a problem hiding this comment.
Elsewhere we log the stream ID as a %d integer. Should we be consistent in the way we log?
There was a problem hiding this comment.
FWIW, I would probably lean towards doing logging in hex as you did it originally, but let’s make that a separate patch.
Lukasa
force-pushed
the
add-extension-frame-support
branch
from
dcfcf34 to
04cf12d
Compare
|
Okay, LGTM. @Lukasa I’ll let you merge, so you can sort out backports and the like. |
|
Cool, thanks @alexwlchan! I'm going to try to write this in as a shell script that we can commit to the repo so that backporting gets a bit easier. |
2 participants
This PR adds support for emitting events when we receive extension frames.
Resolves #435.
The first few commits in here should be backported to older versions of hyper-h2 to allow them to use the 5.0 release series of hyperframe if needed.