Add links to source and download #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
commented
Apr 2, 2025
Comment on lines
+58
to
+60
| Currently being translated into <strong>{{ completion_progress|length }}</strong> languages. | ||
| The documentation has a word count of {{ '{:,}'.format(word_count) }}. | ||
| For more information about translations, see the <a href="https://devguide.python.org/documentation/translating/">Python Developer’s Guide</a> and <a href="https://peps.python.org/pep-0545/">PEP 545</a>. |
There was a problem hiding this comment.
Awkward wording, any ideas on how to improve?
m-aciek
requested changes
Apr 30, 2025
| <p>The Python documentation currently has a word count of {{ '{:,}'.format(word_count) }}.</p> | ||
| <p>For more information about translations, see the <a href="https://devguide.python.org/documentation/translating/">Python Developer’s Guide</a>.</p> | ||
| <p>Last updated at {{ generation_time.strftime('%A, %-d %B %Y, %-H:%M:%S %Z') }} (in {{ duration // 60 }}:{{ "{:02}".format(duration % 60) }} minutes).</p> | ||
| <h3>Python Documentation</h3> |
There was a problem hiding this comment.
I think there's no need to introduce heading and a separate footer. I'd keep the regular three paragraphs.
| <p>Last updated at {{ generation_time.strftime('%A, %-d %B %Y, %-H:%M:%S %Z') }} (in {{ duration // 60 }}:{{ "{:02}".format(duration % 60) }} minutes).</p> | ||
| <h3>Python Documentation</h3> | ||
| <p> | ||
| Currently being translated into <strong>{{ completion_progress|length }}</strong> languages. |
There was a problem hiding this comment.
Probably a matter of taste, in my opinion there's no need to emphasise the number (<strong>).
Comment on lines
+56
to
+60
| <h3>Python Documentation</h3> | ||
| <p> | ||
| Currently being translated into <strong>{{ completion_progress|length }}</strong> languages. | ||
| The documentation has a word count of {{ '{:,}'.format(word_count) }}. | ||
| For more information about translations, see the <a href="https://devguide.python.org/documentation/translating/">Python Developer’s Guide</a> and <a href="https://peps.python.org/pep-0545/">PEP 545</a>. |
There was a problem hiding this comment.
PEP 545 is linked at the top of the linked chapter of the developer's guide, I'd keep one link in this sentence for simplicity.
| </p> | ||
| <footer> | ||
| <hr> | ||
| <p>You can download the data on this page in <code>.json</code> format <a href="https://github.com/python-docs-translations/dashboard/blob/gh-pages/index.json">here</a>, and you can also find the scripts used to generate this page <a href="https://github.com/python-docs-translations/dashboard">here</a>. |
There was a problem hiding this comment.
Suggested change
| <p>You can download the data on this page in <code>.json</code> format <a href="https://github.com/python-docs-translations/dashboard/blob/gh-pages/index.json">here</a>, and you can also find the scripts used to generate this page <a href="https://github.com/python-docs-translations/dashboard">here</a>. | |
| <p>You can download the data on this page in <a href="https://github.com/python-docs-translations/dashboard/blob/gh-pages/index.json">JSON format</a>. You can also find the scripts used to generate those pages or contribute <a href="https://github.com/python-docs-translations/dashboard">here</a>. |
Comment on lines
+40
to
+44
| <footer> | ||
| <hr> | ||
| <p>You can find the scripts used to generate this page <a href="https://github.com/python-docs-translations/dashboard">here</a>.</p> | ||
| <p>Last updated at {{ generation_time.strftime('%A, %-d %B %Y, %-H:%M:%S %Z') }} (in {{ duration // 60 }}:{{ "{:02}".format(duration % 60) }} minutes).</p> | ||
| </footer> |
There was a problem hiding this comment.
I'd leave only "last updated" paragraph on the metadata page as a regular paragraph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added translations count and split the footer from the informational text.
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/83/merge/