Make /lib64 mount optional#260
Merged
Merged
Conversation
This path does not exist on ARM-based architectures, all necessary system libraries should be present in /lib and removing this mount entirely works fine on ARM architectures. Adding the "mandatory: false" will still generate a warning on ARM systems (where the path does not exist) but will not fail the nsjail process.
ChrisLovering
approved these changes
Jun 28, 2026
|
coverage: 88.345%. remained the same — jb3/optional-lib64-mount into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snekbox currently fails using on ARM systems (with the images introduced in #258) as the
/lib64path we mount as part of the default config does not exist on ARM platforms.All necessary system libraries should be present in /lib when on ARM and removing this mount entirely works fine on ARM architectures.
Adding the "mandatory: false" will still generate a warning on ARM systems (where the path does not exist) but will not fail the nsjail process, which I think is fine. If we want we could try remove the warning but given we run snekbox on AMD in production I don't think it's a major issue.