Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenGraph metadata #32

Merged
merged 1 commit into from
Mar 1, 2018
Merged

OpenGraph metadata #32

merged 1 commit into from
Mar 1, 2018

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Mar 1, 2018

Adds OpenGraph metadata to the site, which allows us to have Discord embeds like the image below.
Embed

Also adds a new logo to static/logos from the branding repo, logo_discord.png

@coveralls
Copy link

Pull Request Test Coverage Report for Build 359

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.777%
Totals Coverage Status
Change from base Build 358: 0.0%
Covered Lines: 346
Relevant Lines: 377
💛 - Coveralls

Zwork101
Zwork101 approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@Zwork101 Zwork101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

lemonsaurus
lemonsaurus approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR.

@lemonsaurus lemonsaurus merged commit 4969415 into master Mar 1, 2018
@jb3 jb3 deleted the open-graph branch March 1, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonsaurus lemonsaurus lemonsaurus approved these changes

@Zwork101 Zwork101 Zwork101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jb3 @coveralls @lemonsaurus @Zwork101