This repository was archived by the owner on Mar 31, 2020. It is now read-only.
Slithering Snacks #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add flake8 plugins * Remove most ignores
|
mm |
This configuration will prevent CR from being committed. Qt Creator
is the main culprit here since there is no setting to change its
default line endings.
Include this config using the command:
git config --local include.path ../.gitconfig
* Replace table widget with a table view * Rename objects
Python code (project/ui/main_window.py) is generated from qt/mainwindow.ui using pyside2-uic. Because it is generated, flake8 is configured to ignore the project/ui directory.
* Add a playlist model for the tree view
An SQLite driver is being used. The database consists of a single table which has fields for metadata as well as the file's path and CRC32.
ffprobe is used to retrieve metadata in JSON format.
json.loads seems to be able to decode an encoded string just fine, but this is some added convenience in case `stderr` is to be read.
* Rename add_entry to add_media * Add docstring to add_media
* Add millisecond constants for hour, minute, and second * Remove redundant lambda in signal connection
* Enable alternating row colours
* Add run script for pipenv
* Create custom signals for media mutation in Player
* Disable horizontal header highlighting when row is selected * Remove some debug logging
If it fails, it displays an error and generates a new CAPTCHA.
* Fix password length check * Ignore B305 flake error
* Use a form layout
* Rename widgets
* Replace the confirm button with a QDialogButtonBox
* Replace display() with open() and exec_() overrides
* Split some behaviour of check() into an override of done()
* Make check() private
* Return error messages in check()
* Set the password and error message in done()
* Clear the inputs and error messages before closing
* Rely on checking result to exit instead of exiting within the class
* Use form layout
* Rename widgets
* Replace the buttons with a QDialogButtonBox
* Replace display() with open() and exec_() overrides
* Split some behaviour of check() into an override of done()
* Make check() private
* Set the error message in done()
* Clear the inputs and error messages before closing
* Rely on checking result to exit instead of exiting within the class
* Fix the result of the password prompt being ignored when play is
pressed
* Switch to a 30% chance for prompt to appear when play is pressed
* Remove "dialog" file references from qmake project file
|
Fancy project! Documentation in README is great and also inside the files with function docstrings being filled in detail, but it would be nice if all functions could be documented. Not sure about delegating the jobs off to Overall code quality is pretty excellent, but you have used a mix of double and single quotes in places. |
|
I think you are mistaken on the mixed single/double quotes. There is a flake8 plugin in place which would cause the linter to fail if that was the case. I double checked anyway and couldn't find any mixed quotes. |
|
Oh yeah, indeed I was. Apologies about that one! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.