Tighter mention filtering in auto-ban mod-alerts#3530
Merged
Conversation
Contributor
Contributor
swfarnsworth
approved these changes
Jun 29, 2026
Contributor
|
Thank you @jb3 for such a quick turnaround on this QoL improvement! |
shtlrs
approved these changes
Jun 29, 2026
shtlrs
left a comment
Contributor
There was a problem hiding this comment.
Dear Joe.
That's it, no monologue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


For filters that resolve to
infraction_type=BAN, the resolver no longer removes the entire mentions action. Instead, it now strips only:@here@everyoneAll other configured guild_pings/dm_pings are preserved and still included in mod alerts (e.g. if a user has explicitly added themselves to a specific filter).
Also added a test for _clean_ban_mentions to verify moderator/here/everyone mentions get removed and other mentions remain.