You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @saviosoaresUFC, thanks for taking the time to contribute! Unfortunately we have a few concerns with this PR that will likely lead to us closing it:
We ask that contributors discuss proposed changes with the team before opening a PR - especially for large refactors. The best place to do that is in the #dev-contrib channel on our Discord server. We'd appreciate chatting with you there before work like this goes ahead.
Per our contributing guidelines, we ask that you don't open a pull request unless you've been assigned to an issue for it first. This is to avoid people putting work into pull requests that we are not able to merge. There isn't an existing issue for this change.
Our linting setup is intentionally tailored to the code style we want to achieve. The too-many-instance-attributes rule isn't something we have enabled. If you think it is something we should enable, please raise an issue or discuss with us in Discord first.
The PR description is written in Portuguese, whilst we welcome contributions from anyone we ask for them to be in English so maintainers can understand justifications for changes and other community members can follow along.
Our contributing guidelines require that you disclose whether AI tools were used to assist with your contribution. Could you let us know if this applies?
If you'd like to contribute in the future, come say hi in #dev-contrib in our Discord server and we can help you get started & point you at an issue that needs solving!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: Reduce number of instance attributes across multiple classes
Problema
Diversas classes no projeto excediam o limite de 7 atributos de instância definido pelo Pylint (
too-many-instance-attributes, R0902).Solução
Os parâmetros de construtor foram agrupados em dataclasses dedicadas, reduzindo a contagem de atributos de instância das classes afetadas.
Padrão utilizado
@dataclass.self.datana view.self.paramparaself.data.param.