Skip to content

Post de presentación e incorporación a la coordinación #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nkrunsh wants to merge 2 commits into from
Closed

Post de presentación e incorporación a la coordinación #157

Nkrunsh wants to merge 2 commits into from

Conversation

@Nkrunsh
Copy link
Member

@Nkrunsh Nkrunsh commented Apr 20, 2025

Cambios Realizados:

  • Incorporación de Imagen 300x300 px
  • Creación de Post de Presentación
  • Incorporación a Coordinación

@Nkrunsh Nkrunsh requested a review from a team as a code owner April 20, 2025 23:38
@Nkrunsh Nkrunsh requested review from Ferx096, Jamadath and yeriel April 20, 2025 23:38
@KrlitosForever KrlitosForever linked an issue Apr 21, 2025 that may be closed by this pull request
Agregar Erickson Gallardo #148
Closed
KrlitosForever
KrlitosForever reviewed Apr 21, 2025
View reviewed changes
Copy link
Member

@KrlitosForever KrlitosForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente @Nkrunsh ahí te deje unos comentarios por si quieres aplicar los cambios sugeridos.
Una vez me comentes lo reviso nuevamente 👍🏻

Tony-Rome
Tony-Rome requested changes Apr 21, 2025
View reviewed changes
Copy link
Member

@Tony-Rome Tony-Rome left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me sumo a las sugerencias de Carlos, son detalles pequeños. Lo que sí pido, favor actualizar nombre de la rama, cambiar la palabra task por change o feature, por ejemplo pch-feature-148-perfil-post

Por lo demás, gracias por la creación del post! 🧙‍♂️

content/images/coordinacion_erickson_gallardo.jpg
Copy link
Member

@Tony-Rome Tony-Rome Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se pide en la docu que sea de 330 x 330 la imagen, aunque viendo el resto de imagenes parece ser que no es obligación.

@KrlitosForever
Copy link
Member

KrlitosForever commented Apr 21, 2025

y no olvidarse de darle estrellita al repo ⭐

@Nkrunsh @KrlitosForever
Aplicación de sugerencias post de presentación
b2febc7 
Se aplican los cambio sugeridos en primera revisión para contenido del post de presentación.

Co-authored-by: Carlos Carrasco Varas <[email protected]>
@Nkrunsh Nkrunsh closed this Apr 24, 2025
@Nkrunsh Nkrunsh deleted the pch-task-148-perfil-post branch April 24, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrlitosForever KrlitosForever KrlitosForever left review comments

@Tony-Rome Tony-Rome Tony-Rome requested changes

@pablolirag pablolirag Awaiting requested review from pablolirag

@ancaneo ancaneo Awaiting requested review from ancaneo

@yeriel yeriel Awaiting requested review from yeriel yeriel is a code owner automatically assigned from python-chile/codeowners

@Jamadath Jamadath Awaiting requested review from Jamadath Jamadath is a code owner automatically assigned from python-chile/codeowners

@Ferx096 Ferx096 Awaiting requested review from Ferx096 Ferx096 is a code owner automatically assigned from python-chile/codeowners

Assignees

@KrlitosForever KrlitosForever

@Nkrunsh Nkrunsh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Agregar Erickson Gallardo

4 participants

@Nkrunsh @KrlitosForever @Tony-Rome