Skip to content

presentacion-blog-md-hd #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jervaal wants to merge 1 commit into from
Closed

presentacion-blog-md-hd #137

jervaal wants to merge 1 commit into from

Conversation

@jervaal
Copy link
Contributor

@jervaal jervaal commented Feb 4, 2025

hola hola! escribí la presentación, estare atento a cualquier comentario!

shoutout to Krlitos por ayudarme con github jejej

@jervaal jervaal requested a review from a team as a code owner February 4, 2025 17:32
BGMP
BGMP requested changes Feb 5, 2025
View reviewed changes
Copy link

@BGMP BGMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, bienvenido 😄

Los archivos del directorio content/ son archivos Markdown, por lo que deben llevar la extensión md.

Por favor, cambia el nombre de la siguiente manera: presentacion-blog-md-hd => presentacion-blog-md-hd.md

Por lo demás, leí el contenido de tu presentación y me parece genial a lo que te dedicas, muy interesante! No encontré errores de ortografía relevantes, así que agregando la extensión debería estar todo bien!

@KrlitosForever KrlitosForever linked an issue Feb 5, 2025 that may be closed by this pull request
presentación-blog-Herbert-Díaz #136
Closed
@Tony-Rome Tony-Rome self-requested a review February 5, 2025 22:58
Tony-Rome
Tony-Rome reviewed Feb 5, 2025
View reviewed changes
Tony-Rome
Tony-Rome reviewed Feb 5, 2025
View reviewed changes
Tony-Rome
Tony-Rome reviewed Feb 5, 2025
View reviewed changes
Tony-Rome
Tony-Rome requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@Tony-Rome Tony-Rome left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Favor de renombrar la rama al siguiente formato: pch-[tipo]-[numero issue]-[titulo cambio]

esto según la docu de trabajo, por ejemplo según tu issue #136 quedaría pch-feature-136-blog-hd

Gracias por la presentación Herbert, está buenísima 😄

@KrlitosForever
Copy link
Member

KrlitosForever commented Apr 21, 2025

Se aplica todo lo solicitado en #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BGMP BGMP BGMP requested changes

@Tony-Rome Tony-Rome Tony-Rome requested changes

@KrlitosForever KrlitosForever Awaiting requested review from KrlitosForever KrlitosForever is a code owner automatically assigned from python-chile/codeowners

@pablolirag pablolirag Awaiting requested review from pablolirag pablolirag is a code owner automatically assigned from python-chile/codeowners

@yeriel yeriel Awaiting requested review from yeriel yeriel is a code owner automatically assigned from python-chile/codeowners

@ancaneo ancaneo Awaiting requested review from ancaneo ancaneo is a code owner automatically assigned from python-chile/codeowners

@Jamadath Jamadath Awaiting requested review from Jamadath Jamadath is a code owner automatically assigned from python-chile/codeowners

@Ferx096 Ferx096 Awaiting requested review from Ferx096 Ferx096 is a code owner automatically assigned from python-chile/codeowners

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

presentación-blog-Herbert-Díaz

5 participants

@jervaal @KrlitosForever @BGMP @Tony-Rome