Allow on_setattr=setters.NO_OP on frozen classes#1515
Open
bysiber wants to merge 1 commit intopython-attrs:mainfrom
Open
Allow on_setattr=setters.NO_OP on frozen classes#1515bysiber wants to merge 1 commit intopython-attrs:mainfrom
bysiber wants to merge 1 commit intopython-attrs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using
on_setattr=setters.NO_OPon individual fields of a frozen class raisesValueError: Frozen classes can't use on_setattr, even thoughNO_OPexplicitly means "do nothing for this attribute's setattr hook."This happens because the check
if a.on_setattr is not NonetreatsNO_OPthe same as any real hook —NO_OPis anobject()sentinel, notNone, so it enters the frozen rejection branch.The fix skips the rejection when
on_setattris specificallyNO_OP, since it's semantically equivalent to having no hook at all. Real hooks likesetters.validateare still correctly rejected on frozen classes.