Skip to content

Add 3.14 to Trove classifiers #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ jobs:
name: Packages
path: dist
- run: tar xf dist/*.tar.gz --strip-components=1
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- uses: hynek/setup-cached-uv@v2

- name: Prepare tox
Expand All @@ -62,7 +66,7 @@ jobs:
run: |
DO_MYPY=1

if [[ "$V" == "3.8" || "$V" == "3.9" ]]; then
if [[ "$V" == "3.8" || "$V" == "3.9" || "$V" == "3.14" ]]; then
DO_MYPY=0
fi

Expand Down
4 changes: 3 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ classifiers = [
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
"Typing :: Typed",
Expand All @@ -30,7 +31,8 @@ dynamic = ["version", "readme"]

[project.optional-dependencies]
tests-mypy = [
'pytest-mypy-plugins; platform_python_implementation == "CPython" and python_version >= "3.10"',
# A transitive dependency of pytest-mypy-plugins doesn't build on 3.14 yet.
'pytest-mypy-plugins; platform_python_implementation == "CPython" and python_version >= "3.10" and python_version < "3.14"',
# Since the mypy error messages keep changing, we have to keep updating this
# pin.
'mypy>=1.11.1; platform_python_implementation == "CPython" and python_version >= "3.10"',
Expand Down
5 changes: 0 additions & 5 deletions tests/test_annotations.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
import attr
import attrs

from attr._compat import PY_3_14_PLUS
from attr._make import _is_class_var
from attr.exceptions import UnannotatedAttributeError

Expand Down Expand Up @@ -588,8 +587,6 @@ def test_self_reference(self, slots):
"""
References to self class using quotes can be resolved.
"""
if PY_3_14_PLUS and not slots:
pytest.xfail("References are changing a lot in 3.14.")

@attr.s(slots=slots, auto_attribs=True)
class A:
Expand All @@ -605,8 +602,6 @@ def test_forward_reference(self, slots):
"""
Forward references can be resolved.
"""
if PY_3_14_PLUS and not slots:
pytest.xfail("Forward references are changing a lot in 3.14.")

@attr.s(slots=slots, auto_attribs=True)
class A:
Expand Down
3 changes: 2 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
[tox]
min_version = 4
# Mypy doesn't run on 3.14 yet.
env_list =
pre-commit,
py3{8,9,10,11,12,13}-tests,
py3{8,9,10,11,12,13,14}-tests,
py3{10,11,12,13}-mypy,
pypy3-tests,
pyright,
Expand Down