Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention what argument has both annotation and type argument #1410

Merged
merged 3 commits into from
Mar 8, 2025

Conversation

hynek
Copy link
Member

@hynek hynek commented Feb 22, 2025

Fixes #1354

@hynek hynek force-pushed the better-error-conflict branch from 0d841b4 to 0204e08 Compare March 6, 2025 08:57
@hynek hynek force-pushed the better-error-conflict branch from 0204e08 to e65217c Compare March 6, 2025 09:00
@hynek hynek enabled auto-merge March 8, 2025 11:40
@Tinche Tinche self-requested a review March 8, 2025 11:53
@hynek hynek added this pull request to the merge queue Mar 8, 2025
Merged via the queue into main with commit 1c962d1 Mar 8, 2025
19 checks passed
@hynek hynek deleted the better-error-conflict branch March 8, 2025 11:55
luketainton pushed a commit to luketainton/pypilot that referenced this pull request Mar 12, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [attrs](https://github.com/python-attrs/attrs) ([changelog](https://www.attrs.org/en/stable/changelog.html)) | project.dependencies | minor | `==25.1.0` -> `==25.2.0` |

---

### Release Notes

<details>
<summary>python-attrs/attrs (attrs)</summary>

### [`v25.2.0`](https://github.com/python-attrs/attrs/blob/HEAD/CHANGELOG.md#2520---2025-03-12)

[Compare Source](python-attrs/attrs@25.1.0...25.2.0)

##### Changes

-   Checking mandatory vs non-mandatory attribute order is now performed after the field transformer, since the field transformer may change attributes and/or their order.
    [#&#8203;1147](python-attrs/attrs#1147)
-   `attrs.make_class()` now allows for Unicode class names.
    [#&#8203;1406](python-attrs/attrs#1406)
-   Speed up class creation by 30%-50% by compiling methods only once and using a variety of other techniques.
    [#&#8203;1407](python-attrs/attrs#1407)
-   The error message if an attribute has both an annotation and a type argument will now disclose *what* attribute seems to be the problem.
    [#&#8203;1410](python-attrs/attrs#1410)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOTYuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE5Ni4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==-->

Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/316
Reviewed-by: Luke Tainton <[email protected]>
Co-authored-by: Renovate [BOT] <[email protected]>
Co-committed-by: Renovate [BOT] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unhelpful message "ValueError: Type annotation and type argument cannot both be present"
2 participants