-
Notifications
You must be signed in to change notification settings - Fork 0
Add gaurdian signature #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Most of my comments are minor and are suggestions. I like you to address them but some of them can be done in subsequent PRs.
rustfmt.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR but there was a long running debate to remove this format and use standard format for more consistency. We have removed it in pyth-crosschain and i think it's better to remove it here (in another PR)
src/main.rs
Outdated
} | ||
} | ||
|
||
tokio::spawn(async move { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason you do it in another task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think unsubscribing is not that important. Just wanted to start the connection asap
This PR implements signature generation for a Wormhole guardian using price update messages from Pythnet.