feat(pyth-lazer-protocol): Implement Protobuf files for Lazer Transactions #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
merolish
reviewed
Apr 4, 2025
| "../../proto/publisher_update.proto", | ||
| ]; | ||
|
|
||
| prost_build::compile_protos(&proto_files, &["../../proto"])?; |
There was a problem hiding this comment.
Nice. A previous colleague wanted to use protox to avoid the protoc dependency, but the latter is readily available anywhere that matters.
merolish
reviewed
Apr 4, 2025
Comment on lines
15
to
16
| PriceUpdateV1 price_update_v1 = 4; | ||
| FundingRateUpdateV1 funding_rate_update_v1 = 5; |
There was a problem hiding this comment.
Assuming we'll be able to put future message types here compatibly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added proto files for the new transaction types Lazer will be supporting. Updated the Rust and JS sdks to generate types based on the new files.
Rationale
Lazer needs to support more types of input and be capable of changing its input schema as updates happen. Using a new format for input provides this flexibility. Using protobuf for message passing provides additional flexibility for updating schemas and also improves the message compression size.
How has this been tested?
Was able to generate types successfully.