Skip to content

Conversation

jayantk
Copy link
Contributor

@jayantk jayantk commented Dec 6, 2021

Added pyproject.toml and some extra metadata to the package description. I also added instructions on how to update PyPi to the readme.

Here's the package on pypi: https://pypi.org/project/pythclient/0.0.2/ . (Note that I added the distribution section to the readme after doing the upload, so it doesn't show up on pypi.)

@jayantk jayantk requested review from SEJeff and erancx December 6, 2021 20:21
Copy link
Contributor

@SEJeff SEJeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I suspect @erancx will want to have an action do this when a new release is tagged. BTW, do you mind tagging the version you released to pypi and pushing that tag?

Copy link
Contributor

@erancx erancx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly my thoughts @SEJeff , I think publishing this should be with CI (Github Action) on a merge to main/tag.

Other than that, looks great!

@jayantk jayantk merged commit d15feb1 into main Dec 7, 2021
@jayantk jayantk deleted the pypi branch December 7, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants