(Refactor) Link to new api reference #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cprussin
requested changes
Aug 15, 2024
|
@aditya520 there's a list of redirects in here https://github.com/pyth-network/documentation/blob/main/next.config.js that you can edit |
aditya520
force-pushed
the
(refactor)-link-to-v2-api-reference
branch
from
9734c73 to
fb4846c
Compare
cprussin
approved these changes
Aug 19, 2024
next.config.js
Outdated
| @@ -118,6 +118,10 @@ const permanentRedirectArray = [ | |||
| ["/documentation", "/home"], | |||
|
|
|||
| ["/api-explorer/:slug*", "/price-feeds/api-reference/:slug*"], | |||
| [ | |||
| "/price-feeds/api-reference/evm/:slug*", | |||
| "https://api-reference.pyth.network/price-feeds/evm/:slug*", | |||
There was a problem hiding this comment.
I probably wouldn't make these permanent redirects either, there's not much of a great reason to make redirects permanent and I could see us changing these in the future.
Rule of thumb is to always make redirects temporary unless you're absolutely certain that it will never change (for instance, http -> https redirect is usually permanent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.