fix: improve error message when parametrize values is not iterable#14712
Closed
fazalpsinfo-cmyk wants to merge 2 commits into
Closed
fix: improve error message when parametrize values is not iterable#14712fazalpsinfo-cmyk wants to merge 2 commits into
fazalpsinfo-cmyk wants to merge 2 commits into
Conversation
When a trailing comma in argnames causes a scalar value to be parsed as a single-element tuple, TypeError is raised on len(None). Catch this and show a helpful error message. Part of pytest-dev#14619
for more information, see https://pre-commit.ci
Member
I have to ask, was a human ever involved in the process of opening this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a trailing comma in argnames causes a scalar value (e.g.
None) to be parsed as a single-element tuple,len(param.values)raisesTypeError: object of type 'NoneType' has no len().This wraps the
len()call in a try/exceptTypeErrorand shows a helpful message explaining the trailing comma pitfall instead of a cryptic crash.Part of #14619
Support my open source work: https://buymeacoffee.com/muhamedfazalps