Expose CaptureManager as public API (#14186)#14662
Open
Aditya-Tripuraneni wants to merge 1 commit into
Open
Conversation
psf-chronographer
Bot
added
the
bot:chronographer:provided
Contributor
Author
|
Bit of an old issue, but I think I have a fix for it. Tests verify no typing regressions as well since that was a concern. Mind taking a review whenever you have some time? @RonnyPfannschmidt |
Contributor
Author
|
Just following up on this PR @RonnyPfannschmidt |
Member
|
As mentioned i. The issue i war to avoid making capture Manager a public api as is as id like a chance to completely reiterate capture mechanism We had no chance to separate intents and implementation there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
CaptureManageras a public API type.This exposes
CaptureManagerviapytest.CaptureManagerso plugin authors can annotate capture-manager lookups without importing from_pytest.capture.Tests and validation:
testing/test_capture.pyto verifypytest.CaptureManager is CaptureManager.testing/typing_checks.pyto verify plugin-style annotation withpytest.CaptureManager.uv run --python 3.10 pytest testing/test_capture.py -k capture_manager_is_public_api.uv run --python 3.10 --with mypy mypy testing/typing_checks.py.Closes #14186