terminal: disable OSC 9;4; terminal progress by default, except on Windows #13971
+89
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
added
the
backport 9.0.x
psf-chronographer
bot
added
the
bot:chronographer:provided
bluetech
force-pushed
the
disable-terminalprogress-by-default2
branch
from
8cb26ed to
9c9bef2
Compare
TERM=dumb shouldn't emit escape codes like terminalprogress does, it would likely come out as literal escape characters.
bluetech
force-pushed
the
disable-terminalprogress-by-default2
branch
from
9c9bef2 to
f95155b
Compare
Member
Author
|
I added two commits: some test mocking cleanup, and a fix to disable when |
nicoddemus
approved these changes
Nov 19, 2025
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
LGTM! Thanks for tackling this solution.
|
iTerm now supports it! Screen.Recording.2025-11-19.at.12.33.20.PM.mov(not disagreeing with this solution, by the way; this makes it possible, though opt-in, to show them on iTerm. Just pointing out the macOS problem has been fixed, and users will likely be asked to upgrade like I was, so the macOS issue is going away hopefully pretty quickly.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13896.
Fix #13972.
Replaces #13967, see discussion there for some more context.