Skip to content

fixtures: workaround PyPy bug which sometimes causes a KeyError crash during collection #13442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

bluetech
Copy link
Member

Fix #13312.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label May 26, 2025
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the bug reports was interesting

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @bluetech!

@bluetech bluetech force-pushed the reorder-items-pypy branch from 82ba788 to aff35e6 Compare May 27, 2025 08:24
@bluetech
Copy link
Member Author

Hmm some tests started failing because of pkg_resources deprecation -- maybe new setuptools release? Didn't happen yesterday. Will check it later.

@RonnyPfannschmidt
Copy link
Member

On modern setuptools its best to not run those tests

Lets skip them if setuptools is modern

@bluetech bluetech force-pushed the reorder-items-pypy branch from aff35e6 to 1fdcf68 Compare May 28, 2025 06:48
@bluetech bluetech enabled auto-merge May 28, 2025 06:58
@bluetech
Copy link
Member Author

From what I can see we don't run coverage for pypy (probably too slow?), so the low patch coverage is expected.

@bluetech bluetech disabled auto-merge May 28, 2025 08:25
@bluetech bluetech merged commit f59e1ad into pytest-dev:main May 28, 2025
27 of 28 checks passed
Copy link

patchback bot commented May 28, 2025

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/f59e1ad661832f18bce28a9522be2c6d37485d09/pr-13442

Backported as #13447

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 28, 2025
fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection
(cherry picked from commit f59e1ad)
bluetech added a commit that referenced this pull request May 28, 2025
…59e1ad661832f18bce28a9522be2c6d37485d09/pr-13442

[PR #13442/f59e1ad6 backport][8.3.x] fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided (automation) changelog entry is part of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression][8.2.2] KeyError sometimes crashes test collection on PyPy while reordering fixtures
4 participants