-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fixtures: workaround PyPy bug which sometimes causes a KeyError
crash during collection
#13442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the bug reports was interesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @bluetech!
82ba788
to
aff35e6
Compare
Hmm some tests started failing because of |
On modern setuptools its best to not run those tests Lets skip them if setuptools is modern |
…sh during collection Fix pytest-dev#13312.
aff35e6
to
1fdcf68
Compare
From what I can see we don't run coverage for pypy (probably too slow?), so the low patch coverage is expected. |
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #13447 🤖 @patchback |
fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection (cherry picked from commit f59e1ad)
…59e1ad661832f18bce28a9522be2c6d37485d09/pr-13442 [PR #13442/f59e1ad6 backport][8.3.x] fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection
Fix #13312.