Fix fixture wrap with pytest 8.4#238
Closed
dvcorreia wants to merge 1 commit intopytest-dev:masterfrom
dvcorreia:fix/fixture-pytest-8.4.0
Closed
Fix fixture wrap with pytest 8.4#238dvcorreia wants to merge 1 commit intopytest-dev:masterfrom dvcorreia:fix/fixture-pytest-8.4.0
dvcorreia wants to merge 1 commit intopytest-dev:masterfrom
dvcorreia:fix/fixture-pytest-8.4.0
Conversation
Pytest 8.4.0 introduced a type for fixtures, removing the __pytest_wrapped__ attribute on a fixture object. See: pytest-dev/pytest#12473
Author
|
Didn't noticed there was already a PR tackling this (#233). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest-8.4.0introduced a type for fixtures, removing the__pytest_wrapped__attribute on a fixture object.Now instead of unwrapping the object, it now keeps
__wrapped__that we can use instead.This issue was breaking the CI on pytest latest (
v8.4.1), so I took the opportunity to addpytest-8.4.0totox.See: pytest-dev/pytest#12473