Tags support for Example sections #413

elchupanebrej · 2021-04-06T07:23:23Z

This covers #411

Example tags could be used for test selection
Example tags could not be used for invoking pytest_bdd_apply_tag hook for now
Add explicit support for multiple Examples sections
"Examples: Vertical" replaced with "Examples Transposed:" for more convenient naming
Examples sections names are parsed (not used now)

Updates from upstream

codecov · 2021-04-06T07:31:18Z

Codecov Report

Merging #413 (f250ea6) into master (0f02d56) will increase coverage by 0.61%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
+ Coverage   96.00%   96.62%   +0.61%     
==========================================
  Files          50       50              
  Lines        1679     1748      +69     
  Branches      159      166       +7     
==========================================
+ Hits         1612     1689      +77     
+ Misses         39       32       -7     
+ Partials       28       27       -1

Impacted Files	Coverage Δ
tests/feature/test_outline_empty_values.py	`100.00% <ø> (ø)`
pytest_bdd/reporting.py	`85.50% <76.47%> (-0.65%)`	⬇️
pytest_bdd/parser.py	`100.00% <100.00%> (+0.44%)`	⬆️
pytest_bdd/scenario.py	`93.06% <100.00%> (+0.51%)`	⬆️
pytest_bdd/types.py	`100.00% <100.00%> (ø)`
pytest_bdd/utils.py	`100.00% <100.00%> (ø)`
tests/feature/test_outline.py	`100.00% <100.00%> (ø)`
tests/feature/test_report.py	`100.00% <100.00%> (+16.21%)`	⬆️
tests/feature/test_tags.py	`100.00% <100.00%> (ø)`
pytest_bdd/hooks.py	`100.00% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f02d56...f250ea6. Read the comment docs.

felipesetti · 2021-05-20T17:10:46Z

Hi, this is a really helpful feature! What is the status of this issue?

diogormendes · 2021-05-20T17:23:44Z

Indeed, this is a very expected feature !! +1

KelvinKSPS · 2021-05-20T17:48:13Z

It is a very expected feature!
Is there anything pending we can help?

elchupanebrej · 2021-05-21T08:25:45Z

pytest_bdd requires original parser to be rewritten. This PR uses and extends old parser, so seems that this PR won't be accepted till work on new parser would be finished(and has to be re-done after)

I'm in progress of development fork of pytest_bdd which uses cucumber.io gherkin parser, which will support this feature from the box (essential for project which I test), but won't get support of code generation and maybe other features of pytest_bdd on start. I think it could take few weeks to show this feature, because I'm busy on my main project

- Example tags could be used for test selection - Example tags could not be used for invoking pytest_bdd_apply_tag hook for now - Add explicit support for multiple Examples sections - "Examples: Vertical" replaced with "Examples Transposed:" for more convenient naming - Examples sections names are parsed (not used now)

elchupanebrej · 2021-06-30T14:06:24Z

Also, this feature aggravate #296 #310

olegpidsadnyi · 2021-08-17T19:09:51Z

pytest_bdd/parser.py

@@ -267,12 +288,20 @@ def params(self):

    def get_example_params(self):
        """Get example parameter names."""
-        return set(self.examples.example_params + self.feature.examples.example_params)
+        return set(
+            chain(


{examples.example_params for examples in chain(...)}?

olegpidsadnyi · 2021-08-17T19:12:09Z

pytest_bdd/parser.py

-            return [self.example_params, params]
-        else:
-            return []
+        self.examples = list(zip(*self.example_param_values))


that looks weird. why does it assign to self in get_() function instead of return?

olegpidsadnyi · 2021-08-17T19:14:20Z

pytest_bdd/scenario.py

+        for param_names in scenario_param_data.keys():
+            parametrize_values = []
+            for param_tags, param_values in scenario_param_data[param_names]:
+                marks = list(map(partial(getattr, pytest.mark), param_tags))


marks = [...]

olegpidsadnyi · 2021-08-17T19:14:46Z

pytest_bdd/scenario.py

+
+            decorator_chain.append(pytest.mark.parametrize(list(param_names), parametrize_values))
+
+        compose = lambda *func: reduce(lambda f, g: lambda x: f(g(x)), func, lambda x: x)


okay.. let's not turn python into haskell

olegpidsadnyi · 2021-08-17T19:27:56Z

README.rst

@@ -496,13 +496,13 @@ pytest-bdd feature file format also supports example tables in different way:
            When I eat <eat> cucumbers
            Then I should have <left> cucumbers

-            Examples: Vertical
+            Examples Transposed:


Is it possible to separate tags from transposed examples into separate PRs? It is very hard to follow what's what

elchupanebrej · 2022-01-04T12:18:40Z

This will be reopened after #475 merge

CuriousQA · 2023-01-05T19:03:18Z

Hey,

I see this is waiting for #475, but the other issue is closed now and the branch is deleted. Kindly suggest when would this be available or if there exists any alternatives.

Regards,

elchupanebrej · 2023-01-06T09:11:57Z

@CuriousQA seems, that this feature (and many others attached to it) won't be implemented in this project, because of internal problems that must be unwrapped at first. The biggest one is a rewriting parser of Gherkin files. This activity seems ongoing, so I decided to make a fork of this project, to have the possibility to implement essential features which I need personally.

That fork supports tags for example sections but doesn't support vertical examples (because they are not a part of the "standard"). You could find it here https://github.com/elchupanebrej/pytest-bdd-ng

CuriousQA · 2023-01-06T21:59:40Z

Thank you @elchupanebrej for your response. I will look into the link you shared it.

Merge pull request #1 from pytest-dev/master

caaf3d8

Updates from upstream

elchupanebrej marked this pull request as draft April 6, 2021 08:36

elchupanebrej force-pushed the examples_tags branch 5 times, most recently from 06bfb00 to dc55288 Compare April 6, 2021 11:48

elchupanebrej marked this pull request as ready for review April 6, 2021 12:49

elchupanebrej and others added 2 commits May 26, 2021 19:24

Merge branch 'pytest-dev:master' into master

2e94b4d

elchupanebrej force-pushed the examples_tags branch from dc55288 to f250ea6 Compare May 27, 2021 11:43

elchupanebrej mentioned this pull request Aug 15, 2021

Tags support for Example sections #411

Closed

olegpidsadnyi requested changes Aug 17, 2021

View reviewed changes

elchupanebrej closed this Mar 4, 2022

elchupanebrej deleted the examples_tags branch April 2, 2022 11:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tags support for Example sections #413

Tags support for Example sections #413

elchupanebrej commented Apr 6, 2021 •

edited

Loading

codecov bot commented Apr 6, 2021 •

edited

Loading

felipesetti commented May 20, 2021 •

edited

Loading

diogormendes commented May 20, 2021

KelvinKSPS commented May 20, 2021

elchupanebrej commented May 21, 2021

elchupanebrej commented Jun 30, 2021

olegpidsadnyi Aug 17, 2021

olegpidsadnyi Aug 17, 2021

olegpidsadnyi Aug 17, 2021

olegpidsadnyi Aug 17, 2021

olegpidsadnyi Aug 17, 2021

elchupanebrej Jan 4, 2022

elchupanebrej commented Jan 4, 2022

CuriousQA commented Jan 5, 2023

elchupanebrej commented Jan 6, 2023

CuriousQA commented Jan 6, 2023


		decorator_chain.append(pytest.mark.parametrize(list(param_names), parametrize_values))

		compose = lambda *func: reduce(lambda f, g: lambda x: f(g(x)), func, lambda x: x)

Tags support for Example sections #413

Tags support for Example sections #413

Conversation

elchupanebrej commented Apr 6, 2021 • edited Loading

codecov bot commented Apr 6, 2021 • edited Loading

Codecov Report

felipesetti commented May 20, 2021 • edited Loading

diogormendes commented May 20, 2021

KelvinKSPS commented May 20, 2021

elchupanebrej commented May 21, 2021

elchupanebrej commented Jun 30, 2021

olegpidsadnyi Aug 17, 2021

Choose a reason for hiding this comment

olegpidsadnyi Aug 17, 2021

Choose a reason for hiding this comment

olegpidsadnyi Aug 17, 2021

Choose a reason for hiding this comment

olegpidsadnyi Aug 17, 2021

Choose a reason for hiding this comment

olegpidsadnyi Aug 17, 2021

Choose a reason for hiding this comment

elchupanebrej Jan 4, 2022

Choose a reason for hiding this comment

elchupanebrej commented Jan 4, 2022

CuriousQA commented Jan 5, 2023

elchupanebrej commented Jan 6, 2023

CuriousQA commented Jan 6, 2023

elchupanebrej commented Apr 6, 2021 •

edited

Loading

codecov bot commented Apr 6, 2021 •

edited

Loading

felipesetti commented May 20, 2021 •

edited

Loading