Re-create the temp directory on resetting the filesystem #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A large number of test modules are not using the patcher to instantiate fake_filesystem and may be mocking or making use of tempdir independently of pyfakefs. Please be careful with this change. |
davidlbaird
reviewed
Apr 23, 2023
davidlbaird
reviewed
Apr 23, 2023
davidlbaird
reviewed
Apr 23, 2023
- the temp dir is now created during filesystem initialization instead of at patcher setup if configured - this is only done by default if created from the Patcher - fixes pytest-dev#814
mrbean-bremen
force-pushed
the
test_other_os
branch
from
f702b3a to
ee102ac
Compare
davidlbaird
reviewed
Apr 23, 2023
davidlbaird
approved these changes
Apr 23, 2023
- change from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly changes the behavior if you are creating a fake filesystem without using any of the recommended methods (e.g. the temp directory is now also created in this case), but I think that this is ok.
Tasks