Skip to content

Added automatic patching of builtin open as other name #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Nov 18, 2018

  • in Python 2, builtin open is now handled by FakeBuiltinModule
  • in Python 3, builtin open is handled via io.open
  • adapted pytest plugin to ensure that open is not patched
    for linecache and dependent tokenize modules
  • importing builtin open as other name does not work with PyPy2
  • see tarfile add method bombs because lstat returns a uid of None #449

- in Python 2, builtin open is now handled by FakeBuiltinModule
- in Python 3, builtin open is handled via io.open
- adapted pytest plugin to ensure that open is not patched
  for linecache and dependent tokenize modules
- importing builtin open as other name does not work with PyPy2
@mrbean-bremen mrbean-bremen merged commit cb6009c into pytest-dev:master Nov 18, 2018
@mrbean-bremen mrbean-bremen deleted the import-open-as branch November 18, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant