Skip to content

Add encoding to ChannelFileWrite #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamzayn19 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add encoding to ChannelFileWrite #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffb623e
Add encoding to channel write files
iamzayn19 Sep 25, 2026
88c2e78
Use news fragment for ChannelFileWrite encoding
iamzayn19 Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/430.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added an ``encoding`` attribute to ``ChannelFileWrite``.
2 changes: 2 additions & 0 deletions src/execnet/gateway_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,8 @@ def __repr__(self) -> str:


class ChannelFileWrite(ChannelFile):
encoding = "utf-8"

def write(self, out: bytes) -> None:
self.channel.send(out)

Expand Down
1 change: 1 addition & 0 deletions testing/test_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ def test_channel_file_write_error(self, gw: Gateway) -> None:
channel = gw.remote_exec("pass")
f = channel.makefile()
assert not f.isatty()
assert f.encoding == "utf-8"
channel.waitclose(TESTTIMEOUT)
with pytest.raises(IOError):
f.write(b"hello")
Expand Down