Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python3.8 #320

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ on:
push:
branches:
- "master"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to drop master separately?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just preparing the switch, not doing directly after

- "main"
- "test-me-*"

pull_request:
branches:
- "master"
- "main"

# Cancel running jobs for the same workflow and branch.
concurrency:
Expand All @@ -34,7 +36,7 @@ jobs:
fail-fast: false
matrix:
os: [ windows-latest, ubuntu-latest ]
python: [ "3.8","3.10","3.11","3.12", "pypy-3.8" ]
python: [ "3.9","3.10","3.11","3.12", "pypy-3.9" ]

steps:
- uses: actions/checkout@v4
Expand Down
Empty file added changelog.d/.keep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I find it better to use a .gitignore for this purpose. It seems more natural in the context of Git… Plus I often put allowed/disallowed file patterns in so it's only possible to commit what's expected.

Also, maybe consider putting this dir into doc/?

Empty file.
1 change: 1 addition & 0 deletions changelog.d/320.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
add towncrier configuration
1 change: 1 addition & 0 deletions changelog.d/320.removal.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
remove python3.8 support
9 changes: 6 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dynamic = ["version"]
description = "execnet: rapid multi-Python deployment"
readme = {"file" = "README.rst", "content-type" = "text/x-rst"}
license = "MIT"
requires-python = ">=3.8"
requires-python = ">=3.9"
authors = [
{ name = "holger krekel and others" },
]
Expand All @@ -22,7 +22,6 @@ classifiers = [
"Operating System :: MacOS :: MacOS X",
"Operating System :: Microsoft :: Windows",
"Operating System :: POSIX",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -96,7 +95,7 @@ include = [
]

[tool.mypy]
python_version = "3.8"
python_version = "3.9"
mypy_path = ["src"]
files = ["src", "testing"]
strict = true
Expand All @@ -112,3 +111,7 @@ module = [
"gevent.thread.*",
]
ignore_missing_imports = true

[tool.towncrier]
filename = "CHANGELOG.rst"
directory = "changelog.d"
4 changes: 2 additions & 2 deletions src/execnet/gateway_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
import traceback
import weakref
from _thread import interrupt_main
from collections.abc import Iterator
from collections.abc import MutableSet
from io import BytesIO
from typing import Any
from typing import Callable
from typing import Iterator
from typing import Literal
from typing import MutableSet
from typing import Protocol
from typing import cast
from typing import overload
Expand Down
6 changes: 3 additions & 3 deletions src/execnet/multi.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@

import atexit
import types
from collections.abc import Iterable
from collections.abc import Iterator
from collections.abc import Sequence
from functools import partial
from threading import Lock
from typing import TYPE_CHECKING
from typing import Any
from typing import Callable
from typing import Iterable
from typing import Iterator
from typing import Literal
from typing import Sequence
from typing import overload

from . import gateway_bootstrap
Expand Down
4 changes: 2 additions & 2 deletions testing/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

import shutil
import sys
from collections.abc import Generator
from collections.abc import Iterator
from functools import lru_cache
from typing import Callable
from typing import Generator
from typing import Iterator

import pytest

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist=py{38,39,310,311,312,pypy38},docs,linting
envlist=py{39,310,311,312,pypy39},docs,linting
isolated_build = true

[testenv]
Expand Down
Loading