Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Witness Lifting (Point Cloud to Simplicial) #20

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Snopoff
Copy link
Contributor

@Snopoff Snopoff commented Jun 26, 2024

This lifting implements lifting that constructs a simplicial complex, called Witness complex, from a point cloud. The Witness complex is computed using the GUDHI library [1]. In the current implementation the Witness complex is defined over a point cloud $W$, called witnesses. From this set, a subset $L$ of landmarks is formed by randomly choosing the points.

Current implementation can only lift to a weak Euclidian Witness complex:

  • weak means that $\sigma \in L$ is witnessed by $w\in W$ if $\forall l\in \sigma, \forall l' \in L: d(w,l)\leq d(w,l')$
  • euclidian means that the set of witnesses and landmarks are in Euclidian space.

output

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@levtelyatnikov
Copy link
Member

Please consider making the tests pass to make this submission valid for the challenge

@gbg141
Copy link
Member

gbg141 commented Jul 8, 2024

Hello @Snopoff! Thank you for your submission. As we near the end of the challenge, I am collecting participant info for the purpose of selecting and announcing winners. Please email me (or have one member of your team email me) at [email protected] so I can share access to the voting form. In your email, please include:

  • your first and last name (as well as any other team members)
  • the title of the method you implemented
  • the input domain of the method you implemented
  • the output domain of the method you implemented
  • your pull request number (Witness Lifting (Point Cloud to Simplicial) #20)

Before July 12, make sure that your submission respects all Submission Requirements laid out on the challenge page. Any submission that fails to meet this criteria will be automatically disqualified.

@gbg141 gbg141 added award-category-1 Lifting to Simplicial or Cell Domain award-category-3 Feature-based Lifting (including those that simultaneously leverage the connectivity) labels Jul 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@497947b). Learn more about missing BASE report.

Files Patch % Lines
modules/data/utils/utils.py 87.50% 1 Missing ⚠️
.../liftings/pointcloud2simplicial/witness_lifting.py 97.05% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage        ?   68.21%           
=======================================
  Files           ?       18           
  Lines           ?      538           
  Branches        ?        0           
=======================================
  Hits            ?      367           
  Misses          ?      171           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbg141 gbg141 added Winner Awarded submission and removed challenge-icml-2024 labels Oct 31, 2024
@gbg141 gbg141 removed the Winner Awarded submission label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
award-category-1 Lifting to Simplicial or Cell Domain award-category-3 Feature-based Lifting (including those that simultaneously leverage the connectivity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants