Skip to content

Add changelog #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add changelog #139

merged 3 commits into from
Feb 29, 2024

Conversation

FabioRosado
Copy link
Contributor

Closes: #13

WebReflection
WebReflection previously approved these changes Feb 28, 2024
Copy link

@WebReflection WebReflection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside my philosophical question, this LGTM 👍

fpliger
fpliger previously approved these changes Feb 28, 2024
Copy link
Contributor

@fpliger fpliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment I have is the same @WebReflection pointed out, around version number (and I think we should address it before merging), otherwise LGTM (approving to avoid another round of review but I think the version should change before we merge)

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (7675dae) to head (a6aa9ca).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files           5        5           
  Lines         328      328           
=======================================
  Hits          317      317           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabioRosado FabioRosado dismissed stale reviews from fpliger and WebReflection via a6aa9ca February 29, 2024 10:54
@FabioRosado
Copy link
Contributor Author

Set it up to 0.3.0 merging now 😁

@FabioRosado FabioRosado merged commit 5a9a006 into pyscript:main Feb 29, 2024
@FabioRosado FabioRosado deleted the fr/changelog branch February 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CHANGELOG
5 participants