-
Notifications
You must be signed in to change notification settings - Fork 25
Add changelog #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beside my philosophical question, this LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only comment I have is the same @WebReflection pointed out, around version number (and I think we should address it before merging), otherwise LGTM (approving to avoid another round of review but I think the version should change before we merge)
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 5 5
Lines 328 328
=======================================
Hits 317 317
Misses 11 11 ☔ View full report in Codecov by Sentry. |
a6aa9ca
Set it up to 0.3.0 merging now 😁 |
Closes: #13