Fix #148 - Use transform from the interpreter #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebReflection
force-pushed
the
issue-148
branch
from
193a628 to
1cc3afa
Compare
WebReflection
force-pushed
the
issue-148
branch
from
1cc3afa to
ac85402
Compare
|
OK, after various tests I couldn't measure any particular slowdown so I guess we should be good in here + test shows the issue now should be resolved for what each interpreter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR uses a quite ugly workaround which goal is to bootstrap coincident in a way that the transformer form the interpreter (which lands after) can be reused.
The issue is a bit of a chicken/egg situation: we bootstrap coincident at the worker level but we are not necessarily sure the interpreter landed and provided a transform utility so we need to lazily find that out.
More tests are needed, especially around performance, but for the time being this is how we're rolling a fix out.