Skip to content

standard CI envs dir & naming conventions #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

standard CI envs dir & naming conventions #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5349d52
ci dir should not be hidden
jGaboardi Jul 12, 2025
633a70e
update dirs in actions
jGaboardi Jul 12, 2025
fb51eef
standardize file & CI env names
jGaboardi Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest']
environment-file: [.ci/py313_latest.yaml]
environment-file: [ci/py313_access-latest.yaml]
experimental: [false]
defaults:
run:
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,17 @@ jobs:
matrix:
os: [ubuntu-latest]
environment-file: [
py311_oldest,
py311_latest,
py312_latest,
py313_latest,
py313_dev,
py311_access-oldest,
py311_access-latest,
py312_access-latest,
py313_access-latest,
py313_access-dev,
Comment on lines +31 to +35
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this was discussed during the dev call? Imho it is redundant given it lives in access repo but have no strong feelings.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, see here. The decision was basically "let James do his thing unless it is absolutely insane."

And Germano and I discussed here in spopt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main issue is that this is how it looks on GitHub. I have to open each to know which env has failed.

Screenshot 2025-07-17 at 15 52 49

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is also by design so it is easier to keep track of exactly which has failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? I don't see the suffixes here, how is that by design?

Copy link
Member Author

@jGaboardi jGaboardi Jul 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are talking about 2 different things. I talking simply about the file name of the testing environments.

Do you mean that the label is longer so it is truncated? Maybe that's simply a browser issue because this is how I see:

Wrong screenshot

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concede your point @martinfleis

Screenshot 2025-07-17 at 10 04 31 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are looking at the result through the Actions tab but this is how it looks like from within the PR. Irrespective of the cause, this change is now making the interaction more complicated while providing little to no value. I am not maintaining access or spopt but if this is supposed to be new default across the federation, I'd like to have a further discussion about it.

Screenshot 2025-07-17 at 16 05 36

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also make copy&paste between subprojects more work as you need to replace the names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are looking at the result through the Actions tab but this is how it looks like from within the PR. Irrespective of the cause, this change is now making the interaction more complicated while providing little to no value.

I already conceded your point there. I had not realized previously that the truncation was happening everywhere on GH. That was my mistake.

It also make copy&paste between subprojects more work as you need to replace the names.

This was my intention – making things explicit to avoid copy&paste mistakes.

I'd like to have a further discussion about it.

I am absolutely on board with more discussion and ideas better than mine. Let's not merge this PR. I'll look back into ones I previously did for spopt etc. as time permits. And also pause on implementing these updates in other packages for now.

]
experimental: [false]
include:
- environment-file: py313_latest
- environment-file: py313_access-latest
os: macos-latest
- environment-file: py313_latest
- environment-file: py313_access-latest
os: windows-latest
fail-fast: false

Expand All @@ -51,7 +51,7 @@ jobs:
- name: setup micromamba
uses: mamba-org/setup-micromamba@v2
with:
environment-file: .ci/${{ matrix.environment-file }}.yaml
environment-file: ci/${{ matrix.environment-file }}.yaml
micromamba-version: "latest"

- name: install package
Expand Down
2 changes: 1 addition & 1 deletion .ci/py311_latest.yaml → ci/py311_access-latest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: test
name: py311_access-latest
channels:
- conda-forge
dependencies:
Expand Down
2 changes: 1 addition & 1 deletion .ci/py311_oldest.yaml → ci/py311_access-oldest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: test
name: py311_access-oldest
channels:
- conda-forge
dependencies:
Expand Down
2 changes: 1 addition & 1 deletion .ci/py312_latest.yaml → ci/py312_access-latest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: test
name: py312_access-latest
channels:
- conda-forge
dependencies:
Expand Down
2 changes: 1 addition & 1 deletion .ci/py313_dev.yaml → ci/py313_access-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: test
name: py313_access-dev
channels:
- conda-forge
dependencies:
Expand Down
2 changes: 1 addition & 1 deletion .ci/py313_latest.yaml → ci/py313_access-latest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: test
name: py313_access-latest
channels:
- conda-forge
dependencies:
Expand Down
Loading