Skip to content

Fix adding label matchers for groups if label not in query #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2023

Conversation

metalmatze
Copy link
Member

Pyrra has indeed a bug when it comes to grouping and returning the correct label matchers, but only in a certain case.

Let's take the original issue's example:
grpc_client_handling_seconds_count{job="parca/parca-agent"} for the total metric does NOT contain a grpc_method label matcher but groups by grpc_method.
However, when querying with a specific group matcher like grpc_method=WriteRaw we didn't add that label matcher to the modified query that we want.

With this fix we now get what we want:

-grpc_client_handling_seconds_count{job="parca/parca-agent"}
+grpc_client_handling_seconds_count{job="parca/parca-agent",grpc_method="WriteRaw"}

Thanks for reporting @PabloPie!

Closes #731

@metalmatze metalmatze added the bug Something isn't working label May 16, 2023
@metalmatze metalmatze merged commit acc552c into release-0.6 May 17, 2023
@metalmatze metalmatze deleted the release-0.6-queries-grouping-fix branch May 17, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant