Fix adding label matchers for groups if label not in query #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyrra has indeed a bug when it comes to grouping and returning the correct label matchers, but only in a certain case.
Let's take the original issue's example:
grpc_client_handling_seconds_count{job="parca/parca-agent"}
for the total metric does NOT contain agrpc_method
label matcher but groups bygrpc_method
.However, when querying with a specific group matcher like
grpc_method=WriteRaw
we didn't add that label matcher to the modified query that we want.With this fix we now get what we want:
Thanks for reporting @PabloPie!
Closes #731