Skip to content

Migration file for slack notification PR #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RonanMorgan
Copy link
Collaborator

Create migration file in sqlalchemy in order to the slack_hook column

@RonanMorgan RonanMorgan requested a review from frgfm June 25, 2025 15:30
@RonanMorgan RonanMorgan self-assigned this Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.94%. Comparing base (b247038) to head (9841caf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage   83.94%   83.94%           
=======================================
  Files          39       39           
  Lines        1202     1202           
=======================================
  Hits         1009     1009           
  Misses        193      193           
Flag Coverage Δ
backend 83.25% <ø> (ø)
client 93.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Quick question: have you tested this does initialize the column with null values when there is already a row?

We need to make sure of this before merging.

@frgfm frgfm added type: fix Something isn't working module: models labels Jun 29, 2025
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Have you tried to run it yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models type: fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants