Support optional pre-commit hooks #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
approved these changes
Dec 23, 2023
OlaRonning
pushed a commit
to aleatory-science/numpyro
that referenced
this pull request
May 6, 2024
* optional pre-commit hooks * add args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For local development, pre-commit hooks are very useful so that the contributor can check the code formatting before every-commit.
For now, this is optional and does not intervene with the CI. In the future, you might want to use the pre-commit configuration as the linter so that everything is in sync and the versions of ruff are not open. See, for example, https://github.com/pymc-labs/pymc-marketing/blob/main/.github/workflows/ci.yml#L25-L26. If you ever decide to go this path I will be happy to support :)