-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve download files page layout #18741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
IMO it should not be just Unless it’s guaranteed that an abi tag |
|
Ok, thanks for your feedback @merwok, and for your comments on the associated issue. re: ABIs, I've added a couple more options above - based on your feedback, I think the third option is best: |
|
Looks like there's a clause for this being added - https://github.com/pypi/warehouse/pull/18741/files#diff-057bf4a747c150d9f3f76db209a6c8f689b023a8e7cd41d96fcc549492889da7R563 - maybe instead of 3, 1 is a better value? |
|
I suggested 3 as threshold: it’s not useful to filter a list of 1 item, or 2 items. |
|
Yep, currently only showing the filters when there are more than 3 wheels, but happy to adjust that value based on feedback :) |
|
Related: #18822 |
|
Updated todo:
I'd love some help on this |
|
I think that last bug can be solved here: https://github.com/pypi/warehouse/blob/main/warehouse/static/js/warehouse/controllers/filter_list_controller.js#L199-L208 |
|
I am interested to contribute to this round two of download file page improvements. I might have some time this weekend to work on this. I'm pleased to see appreciation of and interest in continuing to improve the initial changes 🙂 Thanks for your work on this @nlhkabu! |
|
My work in progress is here: https://github.com/pypi/warehouse/compare/main...cofiem:warehouse:feature/improve-download-files-page?expand=1 |
|
I think I've addressed all of the todo list in my PR. |





Closes #18732 and #18796