Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ngwaf to pypi instances #172

Merged
merged 8 commits into from
Sep 27, 2024
Merged

feat: add ngwaf to pypi instances #172

merged 8 commits into from
Sep 27, 2024

Conversation

JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Sep 17, 2024 •
edited
Loading

What

  • Adds Fastlys NGWAF to PyPI on both environments, enabling only for test (which is even still in observe only mode)

The "observe" mode is done via SigSci UI at the moment for pypi-test site:
image

@JacobCoffee

This comment was marked as resolved.

Sign in to view
@JacobCoffee JacobCoffee marked this pull request as ready for review September 18, 2024 19:47
miketheman
miketheman reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions inline.

We verbally discussed some concepts on how we might want to tackle workflow changes via UI and getting them back into IaC which is still up in the air.

@JacobCoffee JacobCoffee merged commit 682d131 into main Sep 27, 2024
1 check passed
@JacobCoffee JacobCoffee deleted the ngwaf branch September 27, 2024 15:37
@miketheman miketheman mentioned this pull request Dec 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketheman miketheman miketheman left review comments

@ewdurbin ewdurbin ewdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacobCoffee @miketheman @ewdurbin