-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
3rdigen/issue3511 #4527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
3rdigen
wants to merge
7,547
commits into
pypa:feature/1696-update-vendored-deps
from
3rdigen:3rdigen/issue3511
Closed
3rdigen/issue3511 #4527
3rdigen
wants to merge
7,547
commits into
pypa:feature/1696-update-vendored-deps
from
3rdigen:3rdigen/issue3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Docs] Add migration for `distutils.core.Command`
* The first instance of LDFLAGS is removed instead of the second to match the style of the preceding environment variables.
Switch to platformdirs
Extract method for resolving the dist. Fixes complexity lint.
Remove reliance on LegacyVersion
The introduced caching can be considered an internal change and minor optimization.
Configured indicates that the function code's itself would be configured, not that it is used by an external party. Switch verb to "used" to be clearer as to how the function is being used.
…heel by setuptools 64 Fixes pypa#3511
…heel by setuptools 64 Fixes pypa#3511
…heel by setuptools 64 Fixes pypa#3511
…heel by setuptools 64 Fixes pypa#3511
@3rdigen You might want to rebase, or redo your changes entirely from https://github.com/pypa/setuptools/tree/main , as you seem to have started your changes on a codebase 32 major versions old. |
…heel by setuptools 64 Fixes pypa#3511
See #4542 (comment). Thank you, @Avasam . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3511
Summary of changes
Closes
Pull Request Checklist
newsfragments/
.(See documentation for details)