Skip to content

3rdigen/issue3511 #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

3rdigen
Copy link

@3rdigen 3rdigen commented Jul 30, 2024

Fixes #3511

Summary of changes

Closes

Pull Request Checklist

abravalheri and others added 30 commits January 7, 2023 15:57
[Docs] Add migration for `distutils.core.Command`
* The first instance of LDFLAGS is removed instead of the second
  to match the style of the preceding environment variables.
Extract method for resolving the dist. Fixes complexity lint.
Legorooj and others added 25 commits March 7, 2023 23:50
The introduced caching can be considered an internal change and minor
optimization.
Configured indicates that the function code's itself would be configured, not that it is used by an external party. Switch verb to "used" to be clearer as to how the function is being used.
@Avasam
Copy link
Contributor

Avasam commented Jul 30, 2024

@3rdigen You might want to rebase, or redo your changes entirely from https://github.com/pypa/setuptools/tree/main , as you seem to have started your changes on a codebase 32 major versions old.

@mergify mergify bot mentioned this pull request Aug 5, 2024
2 tasks
@abravalheri
Copy link
Contributor

See #4542 (comment).

Thank you, @Avasam .

@abravalheri abravalheri closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.