Fix find_distributions with non-empty context #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
reviewed
Apr 10, 2025
Co-authored-by: Anderson Bravalheri <[email protected]>
|
Would it be possible to add a test for this, to help ensure we don't regress on this behaviour in the future? |
|
Sure, I added a new test (and found a problem in existing one - there was a typo in I didn't have much time to look into it up until today, so it took a little longer; sorry about that. |
1 task
|
Small update: I now tested the patched version with build of ~120 different Python packages and everything seems to work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_distributionsnow honorsnameparameter from the originalcontext.Closes #211.