Skip to content

Show time taken to download instead of eta 0:00:00 in Rich Progress #13486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 26, 2025

Conversation

qraqras
Copy link
Contributor

@qraqras qraqras commented Jul 18, 2025

Close #13483

Thanks!

@notatallshaw
Copy link
Member

Thanks for your PR to pip. Please be aware all maintainers are volunteers so it may take a moment for someone to review.

That said, let me know if you need any help fixing the the linting and pre-commit errors, you should be able to locally run them following this guide: https://pip.pypa.io/en/stable/development/getting-started/#running-linters

Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space, but there isn't much we can do about that unfortunately. It'd be nice if Rich wouldn't add the space if the column was empty, but looking at the codebase, such a change seems nontrivial.

image

@ichard26 ichard26 merged commit 687742a into pypa:main Jul 26, 2025
29 checks passed
@ichard26
Copy link
Member

Thank you @qraqras for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When download is finished show time taken instead of eta 0:00:00
4 participants