Avoid pip install --dry-run downloading full wheels
#13482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
commented
Jul 15, 2025
| @@ -180,11 +180,6 @@ def resolve( | |||
|
|
|||
| req_set.add_named_requirement(ireq) | |||
|
|
|||
| reqs = req_set.all_requirements | |||
| self.factory.preparer.prepare_linked_requirements_more(reqs) | |||
There was a problem hiding this comment.
This is the key change - the resolver no longer triggers additional preparation. Instead, we move this responsibility to consumers of the resolve result.
Technically, I could have made the preparer aware of the fact that we don't want to download anything, but the preparer is already a grab-bag of flags, and it felt cleaner to do it this way.
|
Thanks for opening the pull request with pip, I'm certainly happy to see this PR, but please be aware it might take a moment for a pip maintainer to review this, as we all do this on a volunteer basis. |
* Removed "more preparation" (downloading) from the resolver to prevent downloading before dry-run validation * Added distribution caching to `InstallRequirement` with `set_dist()` and `get_dist()` methods to preserve metadata-only distributions * Set `download_info` during metadata-only fetching to ensure it's available for commands like `pip lock` and `--report` without requiring full downloads Closes pypa#12603.
pelson
force-pushed
the
feature/no-download-for-dry-run
branch
from
ff4715b to
196f992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12603.
InstallRequirementwithset_dist()andget_dist()methods to preserve metadata-only distributionsdownload_infoduring metadata-only fetching to ensure it's available for commands likepip lockand--reportwithout requiring full downloads