Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install svn on unbutu for github workflows #13149

Closed
wants to merge 7 commits into from

Conversation

notatallshaw
Copy link
Member

No description provided.

@ichard26
Copy link
Member

image

I don't understand why CI is blowing on Ubuntu 24.04 with PEP 668 errors. Is the virtual environment sitecustomize functionality somehow broken...? I'm on an Ubuntu 24.04 install myself and the test suite is passing...

@notatallshaw
Copy link
Member Author

notatallshaw commented Jan 10, 2025

Perhaps there is a difference between where the tests set up the externally managed file and where it should set up on the 24.04 runner?

I don't have time to look right now, if it's non obvious we could always pin the previous runner.

@notatallshaw
Copy link
Member Author

notatallshaw commented Jan 10, 2025

So, for at least one of the tests, the virtual environment created seems to be refusing to do user installs:

ERROR: Can not perform a '--user' install. User site-packages are not visible in this virtualenv

Where as the test is expecting it to refuse to do an externally managed install.

I don't know why this started on Ubuntu 24.04, perhaps they've patched venv to different default settings?

It's perhaps possible to change the values in pyenv.cfg to allow user installs and show that under this circumstance externally managed will still block installs, which I think expresses the intent of this test. Or if venv is patched in such a way this isn't possible, also accept that error message for user installs?

Verified

This commit was signed with the committer’s verified signature.
sumandari sumandari

Verified

This commit was signed with the committer’s verified signature.
sumandari sumandari

Verified

This commit was signed with the committer’s verified signature.
sumandari sumandari
@notatallshaw notatallshaw force-pushed the install-svn-on-ubuntu branch from 018a35d to 2547cd1 Compare February 9, 2025 18:24
@notatallshaw
Copy link
Member Author

There's some details about the Ubuntu 24.04 image to do with user instals / virtual environments that I don't understand.

I could just override it for the specific tests that are failing, but without spending some time understanding the differences between the GitHub image and my local Ubuntu 24.04, and the semantics of the test I worry that I would be invalidating the tests.

I might come back to this if no one else fixes it, but for now I'm closing it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants